linux-kernel - [PATCH v2] mmc: sdio: fix kernel panic when remove non-standard SDIO card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Oct 2022 11:49:51 +0800
From:   Weizhao Ouyang <ouyangweizhao@...u.com>
To:     Ulf Hansson <ulf.hansson@...aro.org>,
        Weizhao Ouyang <o451686892@...il.com>,
        Matthew Ma <mahongwei@...u.com>,
        Sergey Shtylyov <s.shtylyov@....ru>,
        John Wang <wangdayu@...u.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Grazvydas Ignotas <notasas@...il.com>
CC:     <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "Weizhao Ouyang" <ouyangweizhao@...u.com>
Subject: [PATCH v2] mmc: sdio: fix kernel panic when remove non-standard SDIO card

From: Weizhao Ouyang <o451686892@...il.com>

From: Matthew Ma <mahongwei@...u.com>

SDIO tuple is only allocated for standard SDIO card, especially it
causes memory corruption issues when the non-standard SDIO card has
removed since the card device's reference counter does not increase for
it at sdio_init_func(), but all SDIO card device reference counter has
decreased at sdio_release_func().

Fixes: 6f51be3d37df ("sdio: allow non-standard SDIO cards")
Signed-off-by: Matthew Ma <mahongwei@...u.com>
Reviewed-by: Weizhao Ouyang <ouyangweizhao@...u.com>
Reviewed-by: John Wang <wangdayu@...u.com>
---
Changes in v2:
-- update Fixes tag

 drivers/mmc/core/sdio_bus.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc/core/sdio_bus.c
index c6268c38c69e..babf21a0adeb 100644
--- a/drivers/mmc/core/sdio_bus.c
+++ b/drivers/mmc/core/sdio_bus.c
@@ -291,7 +291,8 @@ static void sdio_release_func(struct device *dev)
 {
 	struct sdio_func *func = dev_to_sdio_func(dev);
 
-	sdio_free_func_cis(func);
+	if (!(func->card->quirks & MMC_QUIRK_NONSTD_SDIO))
+		sdio_free_func_cis(func);
 
 	kfree(func->info);
 	kfree(func->tmpbuf);
-- 
2.25.1