linux-kernel - Re: [PATCH] x86/fpu: Remove dynamic features from xcomp_bv for init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <084b98d1-1021-14fd-0d7b-3b85ffee3035@intel.com>
Date:   Thu, 13 Oct 2022 20:53:54 -0700
From:   "Chang S. Bae" <chang.seok.bae@...el.com>
To:     Dave Hansen <dave.hansen@...el.com>,
        "Yao, Yuan" <yuan.yao@...el.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "x86@...nel.org" <x86@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86/fpu: Remove dynamic features from xcomp_bv for
 init_fpstate

On 10/13/2022 10:44 AM, Dave Hansen wrote:
> 
> A better comment for that would be:
> 
> 	 * Some user_xfeatures may not be present in the fpstate.
> 	 * Remove those from 'mask' to zero those features in the
> 	 * user buffer instead of retrieving them from fpstate.

Yes, indeed!

Also this xstate copy routine looks to need some updates.

If an xfeature is present in fpstate, and in init state, the value is 
retrieved from init_fpstate via copy_feature(). But, it has no space for 
dynamic states. Also, for extended states, the init state is known to be 
zero.

Then, perhaps, init_fpstate is better not to be accessed in the 
for_each_extended_xfeature loop; instead of using copy_feature(), the 
feature can be zeroed like this:

diff --git a/arch/x86/kernel/fpu/xstate.c b/arch/x86/kernel/fpu/xstate.c
index 13b83b11b3d8..0fdfd03938b6 100644
--- a/arch/x86/kernel/fpu/xstate.c
+++ b/arch/x86/kernel/fpu/xstate.c
@@ -1150,11 +1150,11 @@ void __copy_xstate_to_uabi_buf(struct membuf to, 
struct fpstate *fpstate,
                          */
                         pkru.pkru = pkru_val;
                         membuf_write(&to, &pkru, sizeof(pkru));
-               } else {
-                       copy_feature(header.xfeatures & BIT_ULL(i), &to,
-                                    __raw_xsave_addr(xsave, i),
-                                    __raw_xsave_addr(xinit, i),
+               } else if (header.xfeatures & BIT_ULL(i)) {
+                       membuf_write(&to, __raw_xsave_addr(xsave, i),
                                      xstate_sizes[i]);
+               } else {
+                       membuf_zero(&to, xstate_sizes[i]);
                 }

Thanks,
Chang