linux-kernel - Re: [PATCH V2 5/5] cachefiles: add restore command to recover inflight ondemand read requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <60a05006-0052-c5eb-8f53-e1ce9ab26142@linux.alibaba.com>
Date:   Fri, 14 Oct 2022 14:33:17 +0800
From:   JeffleXu <jefflexu@...ux.alibaba.com>
To:     Jia Zhu <zhujia.zj@...edance.com>, dhowells@...hat.com,
        xiang@...nel.org
Cc:     linux-cachefs@...hat.com, linux-erofs@...ts.ozlabs.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        yinxin.x@...edance.com, Gao Xiang <hsiangkao@...ux.alibaba.com>
Subject: Re: [PATCH V2 5/5] cachefiles: add restore command to recover
 inflight ondemand read requests



On 10/14/22 11:07 AM, Jia Zhu wrote:
> Previously, in ondemand read scenario, if the anonymous fd was closed by
> user daemon, inflight and subsequent read requests would return EIO.
> As long as the device connection is not released, user daemon can hold
> and restore inflight requests by setting the request flag to
> CACHEFILES_REQ_NEW.
> 
> Suggested-by: Gao Xiang <hsiangkao@...ux.alibaba.com>
> Signed-off-by: Jia Zhu <zhujia.zj@...edance.com>
> Signed-off-by: Xin Yin <yinxin.x@...edance.com>

LGTM.

Reviewed-by: Jingbo Xu <jefflexu@...ux.alibaba.com>

-- 
Thanks,
Jingbo