linux-kernel - Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2022 20:37:44 -0400
From:   Richard Acayan <mailingradian@...il.com>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Ulf Hansson <ulf.hansson@...aro.org>, agross@...nel.org,
        andersson@...nel.org, adrian.hunter@...el.com,
        linux-arm-msm@...r.kernel.org, linux-mmc@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.0 39/44] mmc: sdhci-msm: add compatible string check for sdm670

> On Mon, Oct 10, 2022 at 07:43:53PM -0400, Richard Acayan wrote:
>>> From: Richard Acayan <mailingradian@...il.com>
>>>
>>> [ Upstream commit 4de95950d970c71a9e82a24573bb7a44fd95baa1 ]
>>>
>>> The Snapdragon 670 has the same quirk as Snapdragon 845 (needing to
>>> restore the dll config). Add a compatible string check to detect the need
>>> for this.
>>>
>>> Signed-off-by: Richard Acayan <mailingradian@...il.com>
>>> Reviewed-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>> Link: https://lore.kernel.org/r/20220923014322.33620-3-mailingradian@gmail.com
>>> Signed-off-by: Ulf Hansson <ulf.hansson@...aro.org>
>>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>>> ---
>>>  drivers/mmc/host/sdhci-msm.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
>>> index dc2991422a87..3a091a387ecb 100644
>>> --- a/drivers/mmc/host/sdhci-msm.c
>>> +++ b/drivers/mmc/host/sdhci-msm.c
>>> @@ -2441,6 +2441,7 @@ static const struct of_device_id sdhci_msm_dt_match[] = {
>>>  	 */
>>>  	{.compatible = "qcom,sdhci-msm-v4", .data = &sdhci_msm_mci_var},
>>>  	{.compatible = "qcom,sdhci-msm-v5", .data = &sdhci_msm_v5_var},
>>> +	{.compatible = "qcom,sdm670-sdhci", .data = &sdm845_sdhci_var},
>>
>>Supporting device trees which are invalid under 6.0 schema? It's not a bug fix,
>>it's a feature.
> 
> Does this not enable hardware to work properly? We take quirks/device
> enablement into stable tree as well.

It does, given that there are no device tree dependency issues. Thanks for the
clarification.