linux-kernel - Re: [PATCH v12] firmware: google: Implement cbmem in sysfs driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y0kOxqyDM3/4HSnx@kroah.com>
Date:   Fri, 14 Oct 2022 09:24:54 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jack Rosenthal <jrosenth@...omium.org>
Cc:     Julius Werner <jwerner@...omium.org>,
        LKML <linux-kernel@...r.kernel.org>,
        chrome-platform@...ts.linux.dev,
        Stephen Boyd <swboyd@...omium.org>,
        Tzung-Bi Shih <tzungbi@...nel.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH v12] firmware: google: Implement cbmem in sysfs driver

On Thu, Oct 13, 2022 at 03:25:58PM -0600, Jack Rosenthal wrote:
> On 2022-10-06 at 08:33 +0200, Greg KH wrote:
> > On Wed, Oct 05, 2022 at 04:26:55PM -0700, Julius Werner wrote:
> > > > If the kernel is reporting a value, that value needs to be documented
> > > > somewhere.  If the kernel is acting on that value, it needs to know what
> > > > those values are.
> > > >
> > > > In this specific instance it seems that the kernel knows a subset of the
> > > > values, and some random userspace tool knows all of them?  Think about
> > > > what you would want to see here if you knew nothing about this at all.
> > > 
> > > The kernel doesn't know any of the values. The kernel is just telling
> > > userspace that spaces with these IDs exist and providing an interface
> > > to access them, it's not supposed to know what any of them mean.
> > 
> > Ah, ok, that was not obvious to me, sorry.  If the kernel is just a
> > pass-through, no objections.
> 
> Does this mean PATCH v13 looks good to you?

No idea, sorry.  It's the middle of the merge window, as my bot told
you, so I can't do anything with changes until after it is over.  Please
relax, there is no rush here...

greg k-h