linux-kernel - Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96ab6836-4650-ee53-a0c9-54b8328b8667@collabora.com>
Date:   Fri, 14 Oct 2022 09:35:28 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>, matthias.bgg@...il.com
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        sam.shih@...iatek.com, hanks.chen@...iatek.com,
        weiyi.lu@...iatek.com, zhiyong.tao@...iatek.com,
        andrew-sh.cheng@...iatek.com, viresh.kumar@...aro.org,
        fparent@...libre.com, mars.cheng@...iatek.com,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/8] arm64: dts: mt2712-evb: Fix usb vbus regulators unit
 names

Il 14/10/22 04:43, Chunfeng Yun ha scritto:
> On Thu, 2022-10-13 at 17:22 +0200, AngeloGioacchino Del Regno wrote:
>> Update the names to regulator-usb-p{0-3}-vbus to fix
>> unit_address_vs_reg
>> warnings for those.
>>
>> Fixes: 1724f4cc5133 ("arm64: dts: Add USB3 related nodes for MT2712")
>> Signed-off-by: AngeloGioacchino Del Regno <
>> angelogioacchino.delregno@...labora.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 8 ++++----
>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> index 638908773706..d31a194124c9 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt2712-evb.dts
>> @@ -50,7 +50,7 @@ extcon_usb1: extcon_iddig1 {
>>   		id-gpio = <&pio 14 GPIO_ACTIVE_HIGH>;
>>   	};
>>   
>> -	usb_p0_vbus: regulator@2 {
>> +	usb_p0_vbus: regulator-usb-p0-vbus {
> Can we modify dt-binding of fixed regulator instead of changing the
> node name,
> since all nodes using fixed regulator may need be changed.
> 

These regulators have no MMIO, nor need any index, so it would be simply
wrong to change the binding and leave them as they are here in the devicetree.

Regards,
Angelo