linux-kernel - Re: [PATCH v2] thermal: imx8mm_thermal: wait for a valid measurement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Oct 2022 09:20:21 +0800
From:   Peng Fan <peng.fan@....nxp.com>
To:     Marcus Folkesson <marcus.folkesson@...il.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Anson Huang <Anson.Huang@....com>
Cc:     linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] thermal: imx8mm_thermal: wait for a valid measurement



On 10/7/2022 3:30 PM, Marcus Folkesson wrote:
> Check if first measurement is still pending or if temperature is out of
> range.
> Return and try again later if that is the case.
> 
> Fixes: 5eed800a6811 ("thermal: imx8mm: Add support for i.MX8MM thermal monitoring unit")
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>

NAK:
Please refer: https://www.nxp.com/docs/en/errata/IMX8MM_0N87W.pdf
ERR051272: TMU: Bit 31 of registers TMU_TSCR/TMU_TRITSR/TMU_TRATSR invalid

Thanks,
Peng.

> ---
> 
> Notes:
>      v2: Also invalidate if temperature > max (125 degrees C)
> 
>   drivers/thermal/imx8mm_thermal.c | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c
> index af666bd9e8d4..e42bf373cebc 100644
> --- a/drivers/thermal/imx8mm_thermal.c
> +++ b/drivers/thermal/imx8mm_thermal.c
> @@ -62,11 +62,17 @@ static int imx8mm_tmu_get_temp(void *data, int *temp)
>   {
>   	struct tmu_sensor *sensor = data;
>   	struct imx8mm_tmu *tmu = sensor->priv;
> -	u32 val;
> +	bool ready;
> +	unsigned long val;
> +
> +	val = readl_relaxed(tmu->base + TRITSR);
> +	ready = test_bit(probe_status_offset(1), &val);
> +	if (!ready)
> +		return -EAGAIN;
>   
> -	val = readl_relaxed(tmu->base + TRITSR) & TRITSR_TEMP0_VAL_MASK;
> +	val = val & TRITSR_TEMP0_VAL_MASK;
>   	*temp = val * 1000;
> -	if (*temp < VER1_TEMP_LOW_LIMIT)
> +	if (*temp < VER1_TEMP_LOW_LIMIT || *temp > VER2_TEMP_HIGH_LIMIT)
>   		return -EAGAIN;
>   
>   	return 0;