[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <024da76e187a1043fcbe47a1ddc32283ab22c0d2.camel@nvidia.com>
Date: Fri, 14 Oct 2022 09:41:00 +0000
From: Jim Lin <jilin@...dia.com>
To: Jonathan Hunter <jonathanh@...dia.com>,
"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC: "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"thierry.reding@...il.com" <thierry.reding@...il.com>,
"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
"mathias.nyman@...el.com" <mathias.nyman@...el.com>
Subject: Re: [PATCH v3] xhci: tegra: USB2 pad power controls
On Wed, 2022-10-12 at 12:43 +0100, Jon Hunter wrote:
> On 12/10/2022 12:18, Greg KH wrote:
> > On Wed, Oct 12, 2022 at 06:25:11PM +0800, Jim Lin wrote:
> > > +static inline struct tegra_xusb *hcd_to_tegra_xusb(struct
> > > usb_hcd *hcd)
> > > +{
> > > + return (struct tegra_xusb *) dev_get_drvdata(hcd-
> > > >self.controller);
> >
> > No need for the cast (and if there was, no need for the extra
> > space).
>
> May be best to drop this inline function completely and call
> dev_get_drvdata() directly. I only see it used in one place.
>
> Jon
>
Thanks, will do.
--nvpublic
Powered by blists - more mailing lists