[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <7cfeafef-519d-b6e7-77fb-bd5e611faf71@allwinnertech.com>
Date: Fri, 14 Oct 2022 17:46:51 +0800
From: Kant Fan <kant@...winnertech.com>
To: Chanwoo Choi <cwchoi00@...il.com>, myungjoo.ham@...sung.com,
kyungmin.park@...sung.com, cw00.choi@...sung.com
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] devfreq: governor: Add a private governor_data for
governors in devfreq
On 10/13/2022 3:19 AM, Chanwoo Choi wrote:
>
> In addition, the devfreq driver pass the 'data' from devfreq driver
> to governor by using devfreq_add_device. I think that 'devfreq driver'
> is more proper
>
> * @data: devfreq driver pass to governors, governor should not change it.
>
> And then, there are extra changes required.
>
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 63347a5ae599..0c59b7978391 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -776,8 +776,7 @@ static void remove_sysfs_files(struct devfreq *devfreq,
> * @dev: the device to add devfreq feature.
> * @profile: device-specific profile to run devfreq.
> * @governor_name: name of the policy to choose frequency.
> - * @data: private data for the governor. The devfreq framework does not
> - * touch this value.
> + * @data: devfreq driver pass to governors, governor should not change it.
> */
> struct devfreq *devfreq_add_device(struct device *dev,
> struct devfreq_dev_profile *profile,
> @@ -1011,8 +1010,7 @@ static void devm_devfreq_dev_release(struct device *dev, void *res)
> * @dev: the device to add devfreq feature.
> * @profile: device-specific profile to run devfreq.
> * @governor_name: name of the policy to choose frequency.
> - * @data: private data for the governor. The devfreq framework does not
> - * touch this value.
> + * @data: devfreq driver pass to governors, governor should not change it.
> *
> * This function manages automatically the memory of devfreq device using device
> * resource management and simplify the free operation for memory of devfreq
>
Dear Chanwoo,
Thanks for your kindly advice. I've modified it as patch-v3 [1]. Please
have a look.
[1]
https://lore.kernel.org/all/20221014094359.100995-1-kant@allwinnertech.com/
--
Best Regards,
Kant Fan
Powered by blists - more mailing lists