linux-kernel - Re: [RFC PATCH v2 1/5] regulator: Add devm helpers for get and enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221014134221.000055de@huawei.com>
Date:   Fri, 14 Oct 2022 13:42:21 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Matti Vaittinen <mazziesaccount@...il.com>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jagath Jog J <jagathjog1996@...il.com>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Cosmin Tanislav <demonsingur@...il.com>,
        <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2 1/5] regulator: Add devm helpers for get and
 enable

On Mon, 10 Oct 2022 12:24:51 +0300
Matti Vaittinen <mazziesaccount@...il.com> wrote:

> Hi Jonathan,
> 
> On 10/9/22 15:24, Jonathan Cameron wrote:
> > On Thu, 6 Oct 2022 19:17:39 +0300
> > Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> >   
> >> On Thu, Oct 06, 2022 at 05:36:52PM +0300, Matti Vaittinen wrote:  
> >>> A few regulator consumer drivers seem to be just getting a regulator,
> >>> enabling it and registering a devm-action to disable the regulator at
> >>> the driver detach and then forget about it.
> >>>
> >>> We can simplify this a bit by adding a devm-helper for this pattern.
> >>> Add devm_regulator_get_enable() and devm_regulator_get_enable_optional()  
> >>
> >> ...
> >>  
> >>> (cherry picked from commit b6058e052b842a19c8bb639798d8692cd0e7589f)  
> >>
> >> Not sure:
> >>   - why this is in the commit message
> >>   - what it points to, since
> >> $ git show b6058e052b842a19c8bb639798d8692cd0e7589f
> >>   fatal: bad object b6058e052b842a19c8bb639798d8692cd0e7589f  
> > 
> > These are now upstream in Linus' tree and in my testing branch.
> > I'd not normally advocate working on top of that (because I rebase it), but
> > if it is useful for this series go ahead.  
> 
> Thanks for the explanation :)
> 
> This series will conflict with my fixup series for triggered-buffer 
> attributes. Hence I though I might combine these two series into one if 
> I need to respin the fixup series. I thought of using the v6.1-rc1 when 
> it is out. (I think the 6.1-rc1 should not be that far away)
> 
> OTOH, I just read your another mail which told that there will be one 
> more driver which will conflict with the fixup coming in during this 
> cycle. If that driver lands in your tree before the fix - then I guess I 
> need to rebase the fixup series (and maybe this too) on top of your tree 
> + add conversion of this new driver. I don't think that would be the 
> testing branch though(?)
I'll be messy, but the majority of that fix series will need to go
in during rcX..

The last patch (refactoring one) will need to wait until those are
upstream and have worked there way around to be in my togreg branch
(I usually rebase that tree only after pull requests, but given this
 is going on I may do an earlier pull request than normal.)

That refactoring patch will probably need to cover the new driver.
I can do that as a fixup whilst applying it though once we get that far.

Jonathan

> 
> Yours
> 	-- Matti	
>