linux-kernel - RE: [PATCH v2 14/19] crypto: x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 14 Oct 2022 14:26:30 +0000
From:   "Elliott, Robert (Servers)" <elliott@....com>
To:     "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "tim.c.chen@...ux.intel.com" <tim.c.chen@...ux.intel.com>,
        "ap420073@...il.com" <ap420073@...il.com>,
        "ardb@...nel.org" <ardb@...nel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 14/19] crypto: x86 - load based on CPU features


> Subject: [PATCH v2 14/19] crypto: x86 - load based on CPU features
>  23 files changed, 230 insertions(+), 8 deletions(-)

Here are some things I've noticed on this patch that will be
addressed in v3.

-  Add aria device table (new algorithm added at end of 6.0)

- Change camellia_avx2 device table to not match on AVX (just AVX2
and AES-NI). There's a separate module for AVX.

- Remove ADX from the curve25519 device table. That is optional,
not mandatory.

- Remove AVX from the sm4-avx2 device table. There's a separate
module for AVX.

Here is a script to review the device table aliases:

modinfo /lib/modules/6.0.0+/kernel/arch/x86/crypto/* | grep -E "filename|alias.*cpu" |
        sed 's/.013D./\tSHA-NI/' |      
        sed 's/.0133./\tADX/' |   
        sed 's/.0130./\t\tAVX512-F/' |  
        sed 's/.0125./\t\tAVX2/' |      
        sed 's/.009C./\t\tAVX/' |       
        sed 's/.0099./\tAES-NI/' |      
        sed 's/.0094./\tXMM4.2/' |      
        sed 's/.0089./\t\tSSSE3/' |     
        sed 's/.0081./\tPCLMULQDQ/' |   
        sed 's/.001A./\tXMM2/' |        # aka sse2
        cat