[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <0d037ef8-e301-c0fd-8020-3846a4762ade@igalia.com>
Date: Fri, 14 Oct 2022 12:19:24 -0300
From: "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org,
linux-fsdevel@...r.kernel.org, linux-efi@...r.kernel.org,
kernel-dev@...lia.com, kernel@...ccoli.net, keescook@...omium.org,
anton@...msg.org, ccross@...roid.com, tony.luck@...el.com
Subject: Re: [PATCH V2 3/3] efi: pstore: Add module parameter for setting the
record size
On 14/10/2022 12:00, Ard Biesheuvel wrote:
> On Fri, 14 Oct 2022 at 16:58, Guilherme G. Piccoli <gpiccoli@...lia.com> wrote:
>>
>> On 14/10/2022 11:46, Ard Biesheuvel wrote:
>>> [...]
>>>> for (;;) {
>>>> - varname_size = EFIVARS_DATA_SIZE_MAX;
>>>> + varname_size = record_size;
>>>>
>>>
>>> I don't think we need this - this is the size of the variable name not
>>> the variable itself.
>>>
>>
>> Ugh, my bad. Do you want to stick with 1024 then?
>
> Yes let's keep this at 1024
Perfect, will re-send after we have more feedback on patches 1 and 2.
Thanks again,
Guilherme
Powered by blists - more mailing lists