linux-kernel - Re: [PATCH] Staging: rtl8192e: fix a brace style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <08887454-0ea8-107d-196d-b21b46e357da@gmail.com>
Date:   Fri, 14 Oct 2022 18:56:08 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Rigel Di Scala <zedr@...r.com>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        rigeld@...il.com
Subject: Re: [PATCH] Staging: rtl8192e: fix a brace style issue

On 10/12/22 23:16, Rigel Di Scala wrote:
> Fixed a coding style issue affecting a conditional if statement.
> 
> Signed-off-by: Rigel Di Scala <zedr@...r.com>
> ---
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 19d13b3fc..e932ad1a9 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -180,11 +180,10 @@ static void rtllib_send_ADDBAReq(struct rtllib_device *ieee, u8 *dst,
>   
>   	skb = rtllib_ADDBA(ieee, dst, pBA, 0, ACT_ADDBAREQ);
>   
> -	if (skb) {
> +	if (skb)
>   		softmac_mgmt_xmit(skb, ieee);
> -	} else {
> +	else
>   		netdev_dbg(ieee->dev, "Failed to generate ADDBAReq packet.\n");
> -	}
>   }
>   
>   static void rtllib_send_ADDBARsp(struct rtllib_device *ieee, u8 *dst,

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>