linux-kernel - Re: [PATCH 3/4] Staging: rtl8192e: make alignment match open parenthesis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <38990e85-b74f-0910-8d64-ad614c3bd8e4@gmail.com>
Date:   Fri, 14 Oct 2022 21:00:50 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Anjandev Momi <anjan@...i.ca>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Staging: rtl8192e: make alignment match open
 parenthesis

On 10/14/22 10:18, Anjandev Momi wrote:
> This patch removes the following checks generated by checkpatch.pl:
> 
> 	./drivers/staging/rtl8192e/rtl819x_BAProc.c:261: CHECK:
> 	Alignment should match open parenthesis
> 	./drivers/staging/rtl8192e/rtl819x_BAProc.c:284: CHECK:
> 	Alignment should match open parenthesis
> 	./drivers/staging/rtl8192e/rtl819x_BAProc.c:421: CHECK:
> 	Alignment should match open parenthesis
> 	./drivers/staging/rtl8192e/rtl819x_BAProc.c:441: CHECK:
> 	Alignment should match open parenthesis
> 
> Signed-off-by: Anjandev Momi <anjan@...i.ca>
> ---
>   drivers/staging/rtl8192e/rtl819x_BAProc.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index f36c24c2a..8d92b3426 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -258,7 +258,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
>   		goto OnADDBAReq_Fail;
>   	}
>   	if (!GetTs(ieee, (struct ts_common_info **)&pTS, dst,
> -	    (u8)(pBaParamSet->field.tid), RX_DIR, true)) {
> +		   (u8)(pBaParamSet->field.tid), RX_DIR, true)) {
>   		rc = ADDBA_STATUS_REFUSED;
>   		netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__);
>   		goto OnADDBAReq_Fail;
> @@ -281,7 +281,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
>   	pBA->ba_start_seq_ctrl = *pBaStartSeqCtrl;
>   
>   	if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) ||
> -	   (ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT))

Did a git pull 2 hours ago.
Cannot apply this patch because IOTAction was already renamed.

Bye Philipp

> +	    (ieee->pHTInfo->IOTAction & HT_IOT_ACT_ALLOW_PEER_AGG_ONE_PKT))
>   		pBA->ba_param_set.field.buffer_size = 1;
>   	else
>   		pBA->ba_param_set.field.buffer_size = 32;
> @@ -418,7 +418,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
>   	}
>   
>   	if (!ieee->current_network.qos_data.active ||
> -		!ieee->pHTInfo->bCurrentHTSupport) {
> +	    !ieee->pHTInfo->bCurrentHTSupport) {
>   		netdev_warn(ieee->dev,
>   			    "received DELBA while QOS or HT is not supported(%d, %d)\n",
>   			    ieee->current_network. qos_data.active,
> @@ -438,7 +438,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb)
>   		struct rx_ts_record *pRxTs;
>   
>   		if (!GetTs(ieee, (struct ts_common_info **)&pRxTs, dst,
> -		    (u8)pDelBaParamSet->field.tid, RX_DIR, false)) {
> +			   (u8)pDelBaParamSet->field.tid, RX_DIR, false)) {
>   			netdev_warn(ieee->dev,
>   				    "%s(): can't get TS for RXTS. dst:%pM TID:%d\n",
>   				    __func__, dst,