linux-kernel - Re: [PATCH 2/2] soc: qcom: stats: Mark device as having no PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <517ccf1b-3ac4-6190-5039-4ef3f4de9840@somainline.org>
Date:   Sat, 15 Oct 2022 13:15:07 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Stephen Boyd <swboyd@...omium.org>, Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] soc: qcom: stats: Mark device as having no PM support



On 15.10.2022 02:46, Stephen Boyd wrote:
> This driver purely exposes information from memory to the kernel. Let's
> mark it as not having any device PM functionality, so that during
> suspend we skip even trying to call a suspend function on this device.
> This clears up suspend logs more than anything else, but it also shaves
> a few cycles off suspend.
> 
> Cc: Konrad Dybcio <konrad.dybcio@...ainline.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Konrad
>  drivers/soc/qcom/qcom_stats.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c
> index d6bfd1bbdc2a..d89453a77408 100644
> --- a/drivers/soc/qcom/qcom_stats.c
> +++ b/drivers/soc/qcom/qcom_stats.c
> @@ -217,6 +217,8 @@ static int qcom_stats_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, root);
>  
> +	device_set_pm_not_required(&pdev->dev);
> +
>  	return 0;
>  }
>