linux-kernel - Re: [PATCH] dt-bindings: clock: Convert qcom,lcc to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c8f33e83-1329-e549-d739-24b33f8633ba@linaro.org>
Date:   Sat, 15 Oct 2022 09:06:11 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Luca Weiss <luca@...tu.xyz>, linux-arm-msm@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: clock: Convert qcom,lcc to DT schema

On 15/10/2022 05:09, Luca Weiss wrote:
> Convert the text bindings for the lcc to yaml format. Doing this showed
> that clocks and clock-names were not documented, so fix that now.
> 
> Signed-off-by: Luca Weiss <luca@...tu.xyz>
> ---
>  .../devicetree/bindings/clock/qcom,lcc.txt    | 22 -----
>  .../devicetree/bindings/clock/qcom,lcc.yaml   | 88 +++++++++++++++++++
>  2 files changed, 88 insertions(+), 22 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/clock/qcom,lcc.txt
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,lcc.txt b/Documentation/devicetree/bindings/clock/qcom,lcc.txt
> deleted file mode 100644
> index a3c78aa88038..000000000000
> --- a/Documentation/devicetree/bindings/clock/qcom,lcc.txt
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -Qualcomm LPASS Clock & Reset Controller Binding
> -------------------------------------------------
> -
> -Required properties :
> -- compatible : shall contain only one of the following:
> -
> -			"qcom,lcc-msm8960"
> -			"qcom,lcc-apq8064"
> -			"qcom,lcc-ipq8064"
> -			"qcom,lcc-mdm9615"
> -
> -- reg : shall contain base register location and length
> -- #clock-cells : shall contain 1
> -- #reset-cells : shall contain 1
> -
> -Example:
> -	clock-controller@...00000 {
> -		compatible = "qcom,lcc-ipq8064";
> -		reg = <0x28000000 0x1000>;
> -		#clock-cells = <1>;
> -		#reset-cells = <1>;
> -	};
> diff --git a/Documentation/devicetree/bindings/clock/qcom,lcc.yaml b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> new file mode 100644
> index 000000000000..03c99435d342
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,lcc.yaml
> @@ -0,0 +1,88 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/qcom,lcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm LPASS Clock & Reset Controller Binding

Drop "Binding"

> +
> +maintainers:
> +  - Bjorn Andersson <andersson@...nel.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,lcc-apq8064
> +      - qcom,lcc-ipq8064
> +      - qcom,lcc-mdm9615
> +      - qcom,lcc-msm8960
> +
> +  clocks:
> +    minItems: 8

Drop minItems

> +    maxItems: 8
> +
> +  clock-names:
> +    minItems: 8

Drop minItems

Best regards,
Krzysztof