lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Oct 2022 16:28:52 +0100 From: Jonathan Cameron <jic23@...nel.org> To: Marcus Folkesson <marcus.folkesson@...il.com> Cc: Kent Gustavsson <kent@...oris.se>, Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] iio: adc: mcp3911: use correct id bits On Mon, 10 Oct 2022 21:46:41 +0200 Marcus Folkesson <marcus.folkesson@...il.com> wrote: > The device ID should be shifted 6 bits to left according to datasheet. > > Fixes: 3a89b289df5d ("iio: adc: add support for mcp3911") > Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com> Applied to the the fixes-togreg branch of iio.git. Thanks, Jonathan > --- > drivers/iio/adc/mcp3911.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c > index e55db02c534f..2c1af11a621f 100644 > --- a/drivers/iio/adc/mcp3911.c > +++ b/drivers/iio/adc/mcp3911.c > @@ -57,8 +57,8 @@ > /* Internal voltage reference in mV */ > #define MCP3911_INT_VREF_MV 1200 > > -#define MCP3911_REG_READ(reg, id) ((((reg) << 1) | ((id) << 5) | (1 << 0)) & 0xff) > -#define MCP3911_REG_WRITE(reg, id) ((((reg) << 1) | ((id) << 5) | (0 << 0)) & 0xff) > +#define MCP3911_REG_READ(reg, id) ((((reg) << 1) | ((id) << 6) | (1 << 0)) & 0xff) > +#define MCP3911_REG_WRITE(reg, id) ((((reg) << 1) | ((id) << 6) | (0 << 0)) & 0xff) > > #define MCP3911_NUM_CHANNELS 2 > #define MCP3911_NUM_SCALES 6
Powered by blists - more mailing lists