linux-kernel - Re: [PATCH 1/3] iio: temperature: ltc2983: allocate iio channels once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Oct 2022 17:35:43 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc:     Cosmin Tanislav <demonsingur@...il.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Cosmin Tanislav <cosmin.tanislav@...log.com>
Subject: Re: [PATCH 1/3] iio: temperature: ltc2983: allocate iio channels
 once

On Fri, 14 Oct 2022 16:18:24 +0100
Jonathan Cameron <Jonathan.Cameron@...wei.com> wrote:

> On Fri, 14 Oct 2022 15:11:47 +0100
> Jonathan Cameron <Jonathan.Cameron@...wei.com> wrote:
> 
> > On Fri, 14 Oct 2022 15:37:22 +0300
> > Cosmin Tanislav <demonsingur@...il.com> wrote:
> >   
> > > From: Cosmin Tanislav <cosmin.tanislav@...log.com>
> > > 
> > > Currently, every time the device wakes up from sleep, the
> > > iio_chan array is reallocated, leaking the previous one
> > > until the device is removed (basically never).
> > > 
> > > Move the allocation to the probe function to avoid this.
> > > 
> > > Signed-off-by: Cosmin Tanislav <cosmin.tanislav@...log.com>    
> > Hi Cosmin,
> > 
> > Please give a fixes tag for this one as we'll definitely want to
> > backport it.
> > 
> > Reply to this patch is fine as b4 will pick it up like any other tag.  
> Fixes: f110f3188e563 ("iio: temperature: Add support for LTC2983")
> 
> (from direct mail)
> 
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> >   
> > > ---
> > >  drivers/iio/temperature/ltc2983.c | 13 ++++++-------
> > >  1 file changed, 6 insertions(+), 7 deletions(-)
> > > 
> > > diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
> > > index b652d2b39bcf..a60ccf183687 100644
> > > --- a/drivers/iio/temperature/ltc2983.c
> > > +++ b/drivers/iio/temperature/ltc2983.c
> > > @@ -1385,13 +1385,6 @@ static int ltc2983_setup(struct ltc2983_data *st, bool assign_iio)
> > >  		return ret;
> > >  	}
> > >  
> > > -	st->iio_chan = devm_kzalloc(&st->spi->dev,
> > > -				    st->iio_channels * sizeof(*st->iio_chan),
> > > -				    GFP_KERNEL);
> > > -
> > > -	if (!st->iio_chan)
> > > -		return -ENOMEM;
> > > -
> > >  	ret = regmap_update_bits(st->regmap, LTC2983_GLOBAL_CONFIG_REG,
> > >  				 LTC2983_NOTCH_FREQ_MASK,
> > >  				 LTC2983_NOTCH_FREQ(st->filter_notch_freq));
> > > @@ -1514,6 +1507,12 @@ static int ltc2983_probe(struct spi_device *spi)
> > >  		gpiod_set_value_cansleep(gpio, 0);
> > >  	}
> > >  
> > > +	st->iio_chan = devm_kzalloc(&spi->dev,
> > > +				    st->iio_channels * sizeof(*st->iio_chan),
> > > +				    GFP_KERNEL);
> > > +	if (!st->iio_chan)
> > > +		return -ENOMEM;
> > > +
> > >  	ret = ltc2983_setup(st, true);
> > >  	if (ret)
> > >  		return ret;    
> > 
> >   
>