linux-kernel - Re: [PATCH 4/7] drm/vc4: dpi: Support RGB565 format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0rt8FIkRniuv0l4@pendragon.ideasonboard.com>
Date:   Sat, 15 Oct 2022 20:29:20 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     Maxime Ripard <mripard@...nel.org>, Eric Anholt <eric@...olt.net>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>, Rob Herring <robh@...nel.org>,
        Emma Anholt <emma@...olt.net>, dri-devel@...ts.freedesktop.org,
        Joerg Quinten <aBUGSworstnightmare@...il.com>,
        Chris Morgan <macromorgan@...mail.com>,
        Dave Stevenson <dave.stevenson@...pberrypi.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] drm/vc4: dpi: Support RGB565 format

Hi Maxime and Chris,

Thank you for the patch.

On Thu, Oct 13, 2022 at 11:56:48AM +0200, Maxime Ripard wrote:
> From: Chris Morgan <macromorgan@...mail.com>
> 
> The RGB565 format with padding over 24 bits
> (MEDIA_BUS_FMT_RGB565_1X24_CPADHI) is supported by the vc4 DPI
> controller as "mode 3".  This is what the Geekworm MZP280 DPI display

The code below uses DPI_FORMAT_16BIT_565_RGB_2. Is that mode 3, or
should the commit message refer to mode 2 ?

With this fixed,

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> uses, so let's add support for it in the DPI controller driver.
> 
> Reviewed-by: Dave Stevenson <dave.stevenson@...pberrypi.com>
> Signed-off-by: Chris Morgan <macromorgan@...mail.com>
> Signed-off-by: Maxime Ripard <maxime@...no.tech>
> ---
>  drivers/gpu/drm/vc4/vc4_dpi.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dpi.c b/drivers/gpu/drm/vc4/vc4_dpi.c
> index 1f8f44b7b5a5..7da3dd1db50e 100644
> --- a/drivers/gpu/drm/vc4/vc4_dpi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dpi.c
> @@ -182,6 +182,10 @@ static void vc4_dpi_encoder_enable(struct drm_encoder *encoder)
>  				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_3,
>  						       DPI_FORMAT);
>  				break;
> +			case MEDIA_BUS_FMT_RGB565_1X24_CPADHI:
> +				dpi_c |= VC4_SET_FIELD(DPI_FORMAT_16BIT_565_RGB_2,
> +						       DPI_FORMAT);
> +				break;
>  			default:
>  				DRM_ERROR("Unknown media bus format %d\n",
>  					  bus_format);
> 

-- 
Regards,

Laurent Pinchart