lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Oct 2022 22:22:30 +0200 From: Philipp Hortmann <philipp.g.hortmann@...il.com> To: Martin Kaiser <martin@...ser.cx>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Larry Finger <Larry.Finger@...inger.net>, Phillip Potter <phil@...lpotter.co.uk>, Michael Straube <straube.linux@...il.com>, Pavel Skripkin <paskripkin@...il.com>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH 10/10] staging: r8188eu: summarize tx/rx and scan blinking On 10/15/22 17:11, Martin Kaiser wrote: > Summarize the code for tx/rx blinking and for scan blinking in blink_work. > The only difference is the delay for scheduling the next worker. > > Signed-off-by: Martin Kaiser <martin@...ser.cx> > --- > drivers/staging/r8188eu/core/rtw_led.c | 19 +++---------------- > 1 file changed, 3 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c > index f8bd183fba1e..ce8de2eb7845 100644 > --- a/drivers/staging/r8188eu/core/rtw_led.c > +++ b/drivers/staging/r8188eu/core/rtw_led.c > @@ -81,21 +81,6 @@ static void blink_work(struct work_struct *work) > schedule_delayed_work(&pLed->blink_work, LED_BLINK_LINK_INTVL); > break; > case LED_BLINK_SCAN: > - pLed->BlinkTimes--; > - if (pLed->BlinkTimes == 0) { > - if (check_fwstate(pmlmepriv, _FW_LINKED)) { > - pLed->CurrLedState = LED_BLINK_NORMAL; > - schedule_delayed_work(&pLed->blink_work, LED_BLINK_LINK_INTVL); > - } else { > - pLed->CurrLedState = LED_BLINK_SLOWLY; > - schedule_delayed_work(&pLed->blink_work, LED_BLINK_NO_LINK_INTVL); > - } > - pLed->bLedBlinkInProgress = false; > - pLed->bLedScanBlinkInProgress = false; > - } else { > - schedule_delayed_work(&pLed->blink_work, LED_BLINK_SCAN_INTVL); > - } > - break; > case LED_BLINK_TXRX: > pLed->BlinkTimes--; > if (pLed->BlinkTimes == 0) { > @@ -109,7 +94,9 @@ static void blink_work(struct work_struct *work) > pLed->bLedBlinkInProgress = false; > pLed->bLedScanBlinkInProgress = false; > } else { > - schedule_delayed_work(&pLed->blink_work, LED_BLINK_FASTER_INTVL); > + schedule_delayed_work(&pLed->blink_work, > + pLed->CurrLedState == LED_BLINK_SCAN ? > + LED_BLINK_SCAN_INTVL : LED_BLINK_FASTER_INTVL); > } > break; > case LED_BLINK_WPS: I cannot apply this patch. Applying: staging: r8188eu: summarize tx/rx and scan blinking error: patch failed: drivers/staging/r8188eu/core/rtw_led.c:81 error: drivers/staging/r8188eu/core/rtw_led.c: patch does not apply Patch failed at 0001 staging: r8188eu: summarize tx/rx and scan blinking
Powered by blists - more mailing lists