lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 16 Oct 2022 11:27:30 -0400 From: Deepak R Varma <drv@...lo.com> To: Julia Lawall <julia.lawall@...ia.fr> Cc: outreachy@...ts.linux.dev, pure.logic@...us-software.ie, johan@...nel.org, elder@...nel.org, gregkh@...uxfoundation.org, greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH] staging: greybus: loopback: enclose macro statements in do-while loop On Sun, Oct 16, 2022 at 05:10:17PM +0200, Julia Lawall wrote: > > > On Sun, 16 Oct 2022, Deepak R Varma wrote: > > > On Sun, Oct 16, 2022 at 04:51:09PM +0200, Julia Lawall wrote: > > > > > > > > > On Sun, 16 Oct 2022, Deepak R Varma wrote: > > > > > > > Include multiple statements of macro definition inside do-while{0} loop > > > > to avoid possible partial program execution. Issue reported by > > > > checkpatch script: > > > > > > > > ERROR: Macros with multiple statements should be enclosed in a do - while loop > > > > > > I don't think this change will compile. See if you can figure out why > > > not. > > > > It did compile. I built the greybus driver and loaded it as well with the > > modinfo tool. Can you please tell why you think it won't compile? > > Do you have a .o file for the .c file that you changed? I see many .o files and a greybus.ko as well, but not the loopback.o Am I missing anything with my configuration? I did set Greybus Support to (M) in the menuconfig. Thank you, ./drv > > julia > > > > > ./drv > > > > > > > > julia > > > > > > > > > > > Signed-off-by: Deepak R Varma <drv@...lo.com> > > > > --- > > > > drivers/staging/greybus/loopback.c | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > > > > index 1a61fce98056..37214cb43937 100644 > > > > --- a/drivers/staging/greybus/loopback.c > > > > +++ b/drivers/staging/greybus/loopback.c > > > > @@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev, \ > > > > static DEVICE_ATTR_RO(name##_avg) > > > > > > > > #define gb_loopback_stats_attrs(field) \ > > > > +do { \ > > > > gb_loopback_ro_stats_attr(field, min, u); \ > > > > gb_loopback_ro_stats_attr(field, max, u); \ > > > > - gb_loopback_ro_avg_attr(field) > > > > + gb_loopback_ro_avg_attr(field); \ > > > > +} while (0) > > > > > > > > #define gb_loopback_attr(field, type) \ > > > > static ssize_t field##_show(struct device *dev, \ > > > > -- > > > > 2.30.2 > > > > > > > > > > > > > > > > > > > > > > > > > > >
Powered by blists - more mailing lists