[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20221017164646.4193618-1-dario.binacchi@amarulasolutions.com>
Date: Mon, 17 Oct 2022 18:46:46 +0200
From: Dario Binacchi <dario.binacchi@...rulasolutions.com>
To: linux-kernel@...r.kernel.org
Cc: Amarula patchwork <linux-amarula@...rulasolutions.com>,
michael@...rulasolutions.com,
Dario Binacchi <dario.binacchi@...rulasolutions.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Tero Kristo <kristo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Tony Lindgren <tony@...mide.com>, linux-clk@...r.kernel.org,
linux-omap@...r.kernel.org
Subject: [PATCH] clk: ti: mux: don't free `parent_names' on kzalloc() failure
Although no operation is performed by kfree() on a NULL pointer, it's
however suboptimal and semantically wrong doing it.
Signed-off-by: Dario Binacchi <dario.binacchi@...rulasolutions.com>
---
drivers/clk/ti/mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/ti/mux.c b/drivers/clk/ti/mux.c
index 46b45b3e8319..1f924db2ad98 100644
--- a/drivers/clk/ti/mux.c
+++ b/drivers/clk/ti/mux.c
@@ -182,7 +182,7 @@ static void of_mux_clk_setup(struct device_node *node)
}
parent_names = kzalloc((sizeof(char *) * num_parents), GFP_KERNEL);
if (!parent_names)
- goto cleanup;
+ return;
of_clk_parent_fill(node, parent_names, num_parents);
--
2.32.0
Powered by blists - more mailing lists