linux-kernel - Re: [PATCH] kcsan: remove rng selftest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2022 11:26:25 -0600
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Marco Elver <elver@...gle.com>
Cc:     dvyukov@...gle.com, kasan-dev@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kcsan: remove rng selftest

On Sun, Oct 16, 2022 at 11:09 PM Marco Elver <elver@...gle.com> wrote:
>
> On Sun, 16 Oct 2022 at 22:07, Marco Elver <elver@...gle.com> wrote:
> >
> > On Sun, 16 Oct 2022 at 21:43, Jason A. Donenfeld <Jason@...c4.com> wrote:
> > >
> > > The first test of the kcsan selftest appears to test if get_random_u32()
> > > returns two zeros in a row, and requires that it doesn't. This seems
> > > like a bogus critera. Remove it.
> > >
> > > Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>
> >
> > Acked-by: Marco Elver <elver@...gle.com>
> >
> > Looks pretty redundant at this point (I think some early version had
> > it because somehow I managed to run the test too early and wanted to
> > avoid that accidentally happening again).
> >
>
> And kindly queue it in your tree with all the rng related changes. Thanks!

Okay sure, will do.

Jason