lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Date:   Tue, 18 Oct 2022 01:31:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [sean-jc:x86/rework_kvm_init 39/39]
 arch/riscv/kvm/../../../virt/kvm/kvm_main.c:5731:17: error: implicit
 declaration of function 'hardware_disable_nolock'; did you mean
 'hardware_disable_all'?

tree:   https://github.com/sean-jc/linux x86/rework_kvm_init
head:   419450c654fa58b3708d7b15cb6b20dfb80b472a
commit: 419450c654fa58b3708d7b15cb6b20dfb80b472a [39/39] KVM: Allow architectures to opt out of generic hardware enabling
config: riscv-randconfig-r034-20221017
compiler: riscv32-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/sean-jc/linux/commit/419450c654fa58b3708d7b15cb6b20dfb80b472a
        git remote add sean-jc https://github.com/sean-jc/linux
        git fetch --no-tags sean-jc x86/rework_kvm_init
        git checkout 419450c654fa58b3708d7b15cb6b20dfb80b472a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/riscv/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_suspend':
>> arch/riscv/kvm/../../../virt/kvm/kvm_main.c:5731:17: error: implicit declaration of function 'hardware_disable_nolock'; did you mean 'hardware_disable_all'? [-Werror=implicit-function-declaration]
    5731 |                 hardware_disable_nolock(NULL);
         |                 ^~~~~~~~~~~~~~~~~~~~~~~
         |                 hardware_disable_all
   arch/riscv/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_resume':
>> arch/riscv/kvm/../../../virt/kvm/kvm_main.c:5741:17: error: implicit declaration of function 'hardware_enable_nolock'; did you mean 'hardware_enable_all'? [-Werror=implicit-function-declaration]
    5741 |                 hardware_enable_nolock(NULL);
         |                 ^~~~~~~~~~~~~~~~~~~~~~
         |                 hardware_enable_all
   arch/riscv/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_exit':
>> arch/riscv/kvm/../../../virt/kvm/kvm_main.c:5960:37: error: 'kvm_reboot_notifier' undeclared (first use in this function); did you mean 'kvm_irq_has_notifier'?
    5960 |         unregister_reboot_notifier(&kvm_reboot_notifier);
         |                                     ^~~~~~~~~~~~~~~~~~~
         |                                     kvm_irq_has_notifier
   arch/riscv/kvm/../../../virt/kvm/kvm_main.c:5960:37: note: each undeclared identifier is reported only once for each function it appears in
   arch/riscv/kvm/../../../virt/kvm/kvm_main.c: At top level:
   arch/riscv/kvm/../../../virt/kvm/kvm_main.c:106:17: warning: 'hardware_enable_failed' defined but not used [-Wunused-variable]
     106 | static atomic_t hardware_enable_failed;
         |                 ^~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +5731 arch/riscv/kvm/../../../virt/kvm/kvm_main.c

6aa8b732ca01c3d drivers/kvm/kvm_main.c Avi Kivity        2006-12-10  5718  
fb3600cc50302c9 virt/kvm/kvm_main.c    Rafael J. Wysocki 2011-03-23  5719  static int kvm_suspend(void)
59ae6c6b87711ce drivers/kvm/kvm_main.c Avi Kivity        2007-02-12  5720  {
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5721          /*
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5722           * Secondary CPUs and CPU hotplug are disabled across the suspend/resume
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5723           * callbacks, i.e. no need to acquire kvm_lock to ensure the usage count
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5724           * is stable.  Assert that kvm_lock is not held as a paranoid sanity
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5725           * check that the system isn't suspended when KVM is enabling hardware.
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5726           */
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5727  	lockdep_assert_not_held(&kvm_lock);
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5728  	lockdep_assert_irqs_disabled();
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5729  
10474ae8945ce08 virt/kvm/kvm_main.c    Alexander Graf    2009-09-15  5730  	if (kvm_usage_count)
75b7127c3858261 virt/kvm/kvm_main.c    Takuya Yoshikawa  2010-11-16 @5731  		hardware_disable_nolock(NULL);
59ae6c6b87711ce drivers/kvm/kvm_main.c Avi Kivity        2007-02-12  5732  	return 0;
59ae6c6b87711ce drivers/kvm/kvm_main.c Avi Kivity        2007-02-12  5733  }
59ae6c6b87711ce drivers/kvm/kvm_main.c Avi Kivity        2007-02-12  5734  
fb3600cc50302c9 virt/kvm/kvm_main.c    Rafael J. Wysocki 2011-03-23  5735  static void kvm_resume(void)
59ae6c6b87711ce drivers/kvm/kvm_main.c Avi Kivity        2007-02-12  5736  {
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5737  	lockdep_assert_not_held(&kvm_lock);
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5738  	lockdep_assert_irqs_disabled();
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5739  
bd02e24b780adda virt/kvm/kvm_main.c    Isaku Yamahata    2022-09-22  5740  	if (kvm_usage_count)
75b7127c3858261 virt/kvm/kvm_main.c    Takuya Yoshikawa  2010-11-16 @5741  		hardware_enable_nolock(NULL);
ca84d1a24c376e0 virt/kvm/kvm_main.c    Zachary Amsden    2010-08-19  5742  }
59ae6c6b87711ce drivers/kvm/kvm_main.c Avi Kivity        2007-02-12  5743  

:::::: The code at line 5731 was first introduced by commit
:::::: 75b7127c3858261fc080dd52a022424a7e7f6ae5 KVM: rename hardware_[dis|en]able() to *_nolock() and add locking wrappers

:::::: TO: Takuya Yoshikawa <yoshikawa.takuya@....ntt.co.jp>
:::::: CC: Avi Kivity <avi@...hat.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (173104 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ