linux-kernel - Re: [PATCH 0/5] fsi: Add regmap and refactor sbefifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y02SztthO39FYIeu@sirena.org.uk>
Date:   Mon, 17 Oct 2022 18:37:18 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Eddie James <eajames@...ux.ibm.com>
Cc:     joel@....id.au, jk@...abs.org, alistair@...ple.id.au,
        linux-kernel@...r.kernel.org, linux-fsi@...ts.ozlabs.org
Subject: Re: [PATCH 0/5] fsi: Add regmap and refactor sbefifo

On Fri, Oct 14, 2022 at 05:05:35PM -0500, Eddie James wrote:
> The SBEFIFO hardware can now be attached over a new I2C endpoint
> interface called the I2C Responder (I2CR). In order to use the
> existing SBEFIFO driver, add regmap drivers for both FSI busses
> and the I2CR. Then, refactor the SBEFIFO and OCC drivers to clean
> up and use the new regmap drivers.

Is there any great reason to provide support in the regmap core for this
rather than just implementing in drivers/fsi?  AFAICT this is just
ending up as an implementation detail of shared code in drivers/fsi and
won't have any external users?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)