[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221017190126.GA2281409-robh@kernel.org>
Date: Mon, 17 Oct 2022 14:01:26 -0500
From: Rob Herring <robh@...nel.org>
To: Neil Armstrong <neil.armstrong@...aro.org>
Cc: Alessandro Zummo <a.zummo@...ertech.it>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Satya Priya <quic_c_skakit@...cinc.com>,
Lee Jones <lee@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Andy Gross <agross@...nel.org>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>,
linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
linux-input@...r.kernel.org
Subject: Re: [PATCH v3 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert
to dt-schema
On Mon, Oct 17, 2022 at 11:45:31AM +0200, Neil Armstrong wrote:
> Convert input/qcom,pm8xxx-pwrkey.txt to YAML, and take in account that
> the PM8921 pwrkey compatible is used as fallback for the PM8018 pwrkey.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> ---
> .../bindings/input/qcom,pm8921-pwrkey.yaml | 75 ++++++++++++++++++++++
> .../bindings/input/qcom,pm8xxx-pwrkey.txt | 46 -------------
> 2 files changed, 75 insertions(+), 46 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
> new file mode 100644
> index 000000000000..9591f77aa22a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/qcom,pm8921-pwrkey.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/qcom,pm8921-pwrkey.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm PM8921 PMIC Power Key
> +
> +maintainers:
> + - Bjorn Andersson <andersson@...nel.org>
> +
> +allOf:
> + - $ref: input.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - qcom,pm8921-pwrkey
> + - qcom,pm8058-pwrkey
> + - items:
> + - enum:
> + - qcom,pm8018-pwrkey
> + - const: qcom,pm8921-pwrkey
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: key release
> + - description: key press
> +
> + debounce:
> + description: |
> + Time in microseconds that key must be pressed or
> + released for state change interrupt to trigger.
Don't need '|' and use standard indentation of 2 chars.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pull-up:
> + description: |
> + Presence of this property indicates that the KPDPWR_N
> + pin should be configured for pull up.
Ditto.
With that,
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists