linux-kernel - Re: [PATCH 4/8] blk-iocost: Remove vrate member in struct ioc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y02oS3f8yTw1r0VC@slm.duckdns.org>
Date:   Mon, 17 Oct 2022 09:08:59 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Kemeng Shi <shikemeng@...wei.com>
Cc:     axboe@...nel.dk, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] blk-iocost: Remove vrate member in struct ioc_now

On Mon, Oct 17, 2022 at 10:00:07AM +0800, Kemeng Shi wrote:
> If we trace vtime_base_rate instead of vtime_rate, there is nowhere to
> access now->vrate except function ioc_now using now->vrate locally.
  ^
  which accesses ("to access" doesn't mean the same thing here)

> Just clean it.
       ^
       remove

> Signed-off-by: Kemeng Shi <shikemeng@...wei.com>

With the above description updates,

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun