linux-kernel - Re: [RESEND PATCH] block, bfq: remove unused variable for bfq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2022 13:22:12 +0800
From:   Yuwei Guan <ssawgyw@...il.com>
To:     Yu Kuai <yukuai1@...weicloud.com>, paolo.valente@...aro.org,
        axboe@...nel.dk
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yuwei.Guan@...krlife.com, "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [RESEND PATCH] block, bfq: remove unused variable for bfq_queue


On 2022/10/17 11:38, Yu Kuai wrote:
> Hi,
>
> 在 2022/10/17 11:20, Yuwei Guan 写道:
>> it defined in d0edc2473be9d, but there's nowhere to use it,
>> so remove it.
>>
>> Signed-off-by: Yuwei Guan <Yuwei.Guan@...krlife.com>
>> Acked-by: Paolo Valente <paolo.valente@...aro.org>
>> ---
>>   block/bfq-iosched.h | 3 ---
>>   1 file changed, 3 deletions(-)
>>
>> diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
>> index 64ee618064ba..6bcef8e5871a 100644
>> --- a/block/bfq-iosched.h
>> +++ b/block/bfq-iosched.h
>> @@ -369,11 +369,8 @@ struct bfq_queue {
>>       unsigned long split_time; /* time of last split */
>>         unsigned long first_IO_time; /* time of first I/O for this 
>> queue */
>> -
>>       unsigned long creation_time; /* when this queue is created */
>>   -    /* max service rate measured so far */
>> -    u32 max_service_rate;
>
> You left two blank lines here. Have you tried checkpatch?
>
> Thanks,
> Kuai

Hi Kuai,

I checked it with checkpatch.pl, but 0 errors, 0 warnings.

I will delete one blank line, then resend it.

>>       /*
>>        * Pointer to the waker queue for this queue, i.e., to the
>>
>