lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Oct 2022 15:54:39 -0500 From: Dan Vacura <w36195@...orola.com> To: linux-usb@...r.kernel.org Cc: Daniel Scally <dan.scally@...asonboard.com>, Thinh Nguyen <Thinh.Nguyen@...opsys.com>, Jeff Vanhoof <qjv001@...orola.com>, Dan Vacura <w36195@...orola.com>, stable@...r.kernel.org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jonathan Corbet <corbet@....net>, Laurent Pinchart <laurent.pinchart@...asonboard.com>, Felipe Balbi <balbi@...nel.org>, Michael Grzeschik <m.grzeschik@...gutronix.de>, Paul Elder <paul.elder@...asonboard.com>, linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org Subject: [PATCH] usb: gadget: uvc: fix dropped frame after missed isoc With the re-use of the previous completion status in 0d1c407b1a749 ("usb: dwc3: gadget: Return proper request status") it could be possible that the next frame would also get dropped if the current frame has a missed isoc error. Ensure that an interrupt is requested for the start of a new frame. Fixes: fc78941d8169 ("usb: gadget: uvc: decrease the interrupt load to a quarter") Cc: <stable@...r.kernel.org> Signed-off-by: Dan Vacura <w36195@...orola.com> --- V1 -> V3: - no change, new patch in series drivers/usb/gadget/function/uvc_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c index bb037fcc90e6..323977716f5a 100644 --- a/drivers/usb/gadget/function/uvc_video.c +++ b/drivers/usb/gadget/function/uvc_video.c @@ -431,7 +431,8 @@ static void uvcg_video_pump(struct work_struct *work) /* Endpoint now owns the request */ req = NULL; - video->req_int_count++; + if (buf->state != UVC_BUF_STATE_DONE) + video->req_int_count++; } if (!req) -- 2.34.1
Powered by blists - more mailing lists