linux-kernel - Re: [PATCH] usb: bdc: change state when port disconnected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81528485-fa80-55ab-16ce-84de520f5262@gmail.com>
Date:   Mon, 17 Oct 2022 14:05:42 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>, justinpopo6@...il.com
Cc:     alcooperx@...il.com, balbi@...nel.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, justin.chen@...adcom.com
Subject: Re: [PATCH] usb: bdc: change state when port disconnected

On 10/10/22 07:58, Florian Fainelli wrote:
> 
> 
> On 10/8/2022 8:44 AM, Greg KH wrote:
>> On Wed, Oct 05, 2022 at 12:13:55PM -0700, justinpopo6@...il.com wrote:
>>> From: Justin Chen <justinpopo6@...il.com>
>>>
>>> When port is connected and then disconnected, the state stays as
>>> configured. Which is incorrect as the port is no longer configured,
>>> but in a not attached state.
>>>
>>> Signed-off-by: Justin Chen <justinpopo6@...il.com>
>>> ---
>>>   drivers/usb/gadget/udc/bdc/bdc_udc.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>
>> What commit id does this fix?  Should it go to older kernels?  If so,
>> how far back?
> 
> This would be:
> 
> Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for Broadcom USB3.0 
> device controller IP BDC")
> 
> that issue was present since the driver was included in Linux with the 
> commit above, we did not really consider it to be a serious enough bug, 
> but I suppose it would not hurt to affix the said Fixes tag.

Greg, are you picking up the patch as-is, or do you need Justin to 
resusbmit with the Fixes: tag added?
-- 
Florian