linux-kernel - Re: [PATCH] drbd: only clone bio if we have a backing device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221017060951.GA28409@lst.de>
Date:   Mon, 17 Oct 2022 08:09:51 +0200
From:   Christoph Hellwig <hch@....de>
To:     Christoph Böhmwalder 
        <christoph.boehmwalder@...bit.com>
Cc:     Jens Axboe <axboe@...nel.dk>,
        Philipp Reisner <philipp.reisner@...bit.com>,
        drbd-dev@...ts.linbit.com, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Joel Colledge <joel.colledge@...bit.com>
Subject: Re: [PATCH] drbd: only clone bio if we have a backing device

On Thu, Oct 13, 2022 at 03:53:52PM +0200, Christoph Böhmwalder wrote:
> +	if (get_ldev(device)) {
> +		req->private_bio = bio_alloc_clone(device->ldev->backing_bdev,
> +						   bio, GFP_NOIO, &drbd_io_bio_set);

This adds an overly long line.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>