linux-kernel - Re: [PATCH v2 0/2] usb: dwc3: revert OTG changes for Intel Merrifield

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2022 22:22:46 +0000
From:   Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <balbi@...nel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Steev Klimaszewski <steev@...i.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 0/2] usb: dwc3: revert OTG changes for Intel Merrifield

On Mon, Oct 17, 2022, Andrey Smirnov wrote:
> On Tue, Sep 27, 2022 at 8:53 AM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > As agreed with the author, the v5.19 change is going to be reverted by
> > this series, so we will collaborate on a new one in the future that
> > brings no regressions.
> >
> > Changelog v2:
> > - added Cc: stable@ and Fixes tags (Greg)
> > - rewritten cover letter to point out what the version is touched and
> >   what the decision made with the author of the original change (Greg)
> > - fixed the placement of one piece of code (Andrey)
> > - added Tested-by tags (Ferry)
> >
> > Andy Shevchenko (2):
> >   Revert "USB: fixup for merge issue with "usb: dwc3: Don't switch OTG
> >     -> peripheral if extcon is present""
> >   Revert "usb: dwc3: Don't switch OTG -> peripheral if extcon is
> >     present"
> >
> 
> To spare everyone the need to read extra long thread in
> [PATCH v2 2/2] Revert "usb: dwc3: Don't switch OTG -> peripheral if
> extcon is present"
> 
> NAK, on the whole series. The regression doesn't repro on my
> Edison/Merriefield setup and doesn't repro on the original reporter's
> HW with my build, so it's very much unclear what's going on and what
> the problem is and until it is the revert doesn't seem warranted.
> Please don't apply this.
> 

Thanks for your tests. The series was already applied. It's a bit messy,
but it seems like we need to revert series as there are already reports
that this it already breaks other setups.

Thanks,
Thinh