linux-kernel - Re: [PATCH] jfs: remove redundant assignments to ipaimap and ipaimap2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2022 17:39:59 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jfs: remove redundant assignments to ipaimap and ipaimap2

On 10/17/22 4:56PM, Colin Ian King wrote:
> The pointers ipaimap and ipaimap2 are initialized with values that are
> never read, they are re-assigned later when they are required. The
> initializations are redundant and can be removed.

Hmm. Or we can remove the later assignments. That would seem more 
consistent with the ipbmap and ipimap.

> 
> Cleans up two clang scan build warnings:
> fs/jfs/jfs_umount.c:42:16: warning: Value stored to 'ipaimap' during
> its initialization is never read [deadcode.DeadStores]
> 
> fs/jfs/jfs_umount.c:43:16: warning: Value stored to 'ipaimap2' during
> its initialization is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>   fs/jfs/jfs_umount.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/jfs/jfs_umount.c b/fs/jfs/jfs_umount.c
> index 3e8b13e6aa01..cc4d7e6e8a4b 100644
> --- a/fs/jfs/jfs_umount.c
> +++ b/fs/jfs/jfs_umount.c
> @@ -39,8 +39,8 @@ int jfs_umount(struct super_block *sb)
>   	struct jfs_sb_info *sbi = JFS_SBI(sb);
>   	struct inode *ipbmap = sbi->ipbmap;
>   	struct inode *ipimap = sbi->ipimap;
> -	struct inode *ipaimap = sbi->ipaimap;
> -	struct inode *ipaimap2 = sbi->ipaimap2;
> +	struct inode *ipaimap;
> +	struct inode *ipaimap2;
>   	struct jfs_log *log;
>   	int rc = 0;
>