linux-kernel - Re: [PATCH v3 2/3] Input: add driver for Himax hx83112b touchscreen devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <CNO39RACPFL9.13SXHBXOMYMT2@ancom>
Date:   Mon, 17 Oct 2022 11:25:57 +0200
From:   "Job Noorman" <job@...rman.info>
To:     "Dmitry Torokhov" <dmitry.torokhov@...il.com>
Cc:     "Henrik Rydberg" <rydberg@...math.org>,
        "Luca Weiss" <luca@...tu.xyz>, <linux-kernel@...r.kernel.org>,
        <linux-input@...r.kernel.org>
Subject: Re: [PATCH v3 2/3] Input: add driver for Himax hx83112b touchscreen
 devices

Hi Dmitry,

Thanks for your review! I've addressed all your comments and will send an
update momentarily. I just have a small reply below.

On Mon Oct 17, 2022 at 6:19 AM CEST, Dmitry Torokhov wrote:
> > +struct himax_event {
> > +	struct himax_event_point points[HIMAX_MAX_POINTS];
> > +	u8 majors[HIMAX_MAX_POINTS];
> > +	u8 pad0[2];
> > +	u8 num_points;
> > +	u8 pad1[2];
> > +	u8 checksum_fix;
> > +} __packed;
> > +
> > +static_assert(sizeof(struct himax_event) == 56);
>
> Is this different from BUILD_BUG_ON()?

Their intent is the same but BUILD_BUG_ON() cannot be used at the global
scope. Hence, static_assert() is necessary here.

Best regards,
Job