linux-kernel - drivers/gpu/drm/tegra/submit.c:107:28: sparse: sparse: symbol 'gather_bo_ops' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202210171730.GhnD4yki-lkp@intel.com>
Date:   Mon, 17 Oct 2022 17:36:11 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mikko Perttunen <mperttunen@...dia.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Thierry Reding <treding@...dia.com>
Subject: drivers/gpu/drm/tegra/submit.c:107:28: sparse: sparse: symbol
 'gather_bo_ops' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   9abf2313adc1ca1b6180c508c25f22f9395cc780
commit: 13abe0bb15ceac2fb8e8853bd30c278426d95ad0 drm/tegra: Implement job submission part of new UAPI
date:   1 year, 2 months ago
config: arm64-randconfig-s052-20221017
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=13abe0bb15ceac2fb8e8853bd30c278426d95ad0
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 13abe0bb15ceac2fb8e8853bd30c278426d95ad0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/gpu/drm/tegra/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/tegra/submit.c:107:28: sparse: sparse: symbol 'gather_bo_ops' was not declared. Should it be static?

vim +/gather_bo_ops +107 drivers/gpu/drm/tegra/submit.c

    66	
    67	static struct host1x_bo_mapping *
    68	gather_bo_pin(struct device *dev, struct host1x_bo *bo, enum dma_data_direction direction)
    69	{
    70		struct gather_bo *gather = container_of(bo, struct gather_bo, base);
    71		struct host1x_bo_mapping *map;
    72		int err;
    73	
    74		map = kzalloc(sizeof(*map), GFP_KERNEL);
    75		if (!map)
    76			return ERR_PTR(-ENOMEM);
    77	
    78		kref_init(&map->ref);
    79		map->bo = host1x_bo_get(bo);
    80		map->direction = direction;
    81		map->dev = dev;
    82	
    83		map->sgt = kzalloc(sizeof(*map->sgt), GFP_KERNEL);
    84		if (!map->sgt) {
    85			err = -ENOMEM;
    86			goto free;
    87		}
    88	
    89		err = dma_get_sgtable(gather->dev, map->sgt, gather->gather_data, gather->gather_data_dma,
    90				      gather->gather_data_words * 4);
    91		if (err)
    92			goto free_sgt;
    93	
    94		err = dma_map_sgtable(dev, map->sgt, direction, 0);
    95		if (err)
    96			goto free_sgt;
    97	
    98		map->phys = sg_dma_address(map->sgt->sgl);
    99		map->size = gather->gather_data_words * 4;
   100		map->chunks = err;
   101	
   102		return map;
   103	
   104	free_sgt:
   105		sg_free_table(map->sgt);
   106		kfree(map->sgt);
 > 107	free:
   108		kfree(map);
   109		return ERR_PTR(err);
   110	}
   111	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (136927 bytes)