[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y00lMjEncoxwkNiJ@spud>
Date: Mon, 17 Oct 2022 10:49:38 +0100
From: Conor Dooley <conor@...nel.org>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc: conor.dooley@...rochip.com, daire.mcnamara@...rochip.com,
broonie@...nel.org, linux-riscv@...ts.infradead.org,
linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] spi: microchip-core: Remove the unused function
mchp_corespi_enable()
On Mon, Oct 17, 2022 at 05:21:41PM +0800, Jiapeng Chong wrote:
> The function mchp_corespi_enable() is defined in the spi-microchip-core.c
> file, but not called elsewhere, so delete this unused function.
>
> drivers/spi/spi-microchip-core.c:122:20: warning: unused function 'mchp_corespi_enable'.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2418
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
> drivers/spi/spi-microchip-core.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
> index d352844c798c..aeaa1da88f39 100644
> --- a/drivers/spi/spi-microchip-core.c
> +++ b/drivers/spi/spi-microchip-core.c
> @@ -119,15 +119,6 @@ static inline void mchp_corespi_write(struct mchp_corespi *spi, unsigned int reg
> writel(val, spi->regs + reg);
> }
>
> -static inline void mchp_corespi_enable(struct mchp_corespi *spi)
> -{
> - u32 control = mchp_corespi_read(spi, REG_CONTROL);
> -
> - control |= CONTROL_ENABLE;
> -
> - mchp_corespi_write(spi, REG_CONTROL, control);
> -}
That's a bit silly... Thanks Jiapeng.
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> -
> static inline void mchp_corespi_disable(struct mchp_corespi *spi)
> {
> u32 control = mchp_corespi_read(spi, REG_CONTROL);
> --
> 2.20.1.7.g153144c
>
Powered by blists - more mailing lists