linux-kernel - Re: [PATCH] perf tools: Fix man page build wrt perf-arm-coresight.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y00nFxrcV7TVqmJO@leoy-yangtze.lan>
Date:   Mon, 17 Oct 2022 17:57:43 +0800
From:   Leo Yan <leo.yan@...aro.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>, suzuki.poulose@....com,
        linux-perf-users@...r.kernel.org, mathieu.poirier@...aro.org,
        mike.leach@...aro.org, Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-kernel@...r.kernel.org, coresight@...ts.linaro.org,
        Sven Schnelle <svens@...ux.ibm.com>,
        James Clark <james.clark@....com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Carsten Haitzler <carsten.haitzler@...s.arm.com>
Subject: Re: [PATCH] perf tools: Fix man page build wrt perf-arm-coresight.txt

On Mon, Oct 17, 2022 at 12:35:49PM +0300, Adrian Hunter wrote:
> perf build assumes documentation files starting with "perf-" are man
> pages but perf-arm-coresight.txt is not a man page:
> 
> asciidoc: ERROR: perf-arm-coresight.txt: line 2: malformed manpage title
> asciidoc: ERROR: perf-arm-coresight.txt: line 3: name section expected
> asciidoc: FAILED: perf-arm-coresight.txt: line 3: section title expected
> make[3]: *** [Makefile:266: perf-arm-coresight.xml] Error 1
> make[3]: *** Waiting for unfinished jobs....
> make[2]: *** [Makefile.perf:895: man] Error 2
> 
> Fix by renaming it.
> 
> Reported-by: Sven Schnelle <svens@...ux.ibm.com>
> Reported-by: Christian Borntraeger <borntraeger@...ux.ibm.com>
> Fixes: dc2e0fb00bb2 ("perf test coresight: Add relevant documentation about ARM64 CoreSight testing")
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>

Thanks for fixing, Adrian.  The change LGTM:

Reviewed-by: Leo Yan <leo.yan@...aro.org>

> ---
>  .../Documentation/{perf-arm-coresight.txt => arm-coresight.txt}   | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename tools/perf/Documentation/{perf-arm-coresight.txt => arm-coresight.txt} (100%)
> 
> diff --git a/tools/perf/Documentation/perf-arm-coresight.txt b/tools/perf/Documentation/arm-coresight.txt
> similarity index 100%
> rename from tools/perf/Documentation/perf-arm-coresight.txt
> rename to tools/perf/Documentation/arm-coresight.txt
> -- 
> 2.25.1
>