lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Oct 2022 10:52:28 +0000 From: Niklas Cassel <Niklas.Cassel@....com> To: John Garry <john.garry@...wei.com> CC: "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>, "martin.petersen@...cle.com" <martin.petersen@...cle.com>, "jinpu.wang@...ud.ionos.com" <jinpu.wang@...ud.ionos.com>, "damien.lemoal@...nsource.wdc.com" <damien.lemoal@...nsource.wdc.com>, "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linuxarm@...wei.com" <linuxarm@...wei.com>, "yangxingui@...wei.com" <yangxingui@...wei.com> Subject: Re: [PATCH v6 1/8] scsi: libsas: Add sas_ata_device_link_abort() On Mon, Oct 17, 2022 at 05:20:28PM +0800, John Garry wrote: > Similar to how AHCI handles NCQ errors in ahci_error_intr() -> > ata_port_abort() -> ata_do_link_abort(), add an NCQ error handler for LLDDs > to call to initiate a link abort. > > This will mark all outstanding QCs as failed and kick-off EH. > > Note: > A "force reset" argument is added for drivers which require the ATA error > handling to always reset the device. > > A driver may require this feature for when SATA device per-SCSI cmnd > resources are only released during reset for ATA EH. As such, we need an > option to force reset to be done, regardless of what any EH autopsy > decides. > > The SATA device FIS fields are set to indicate a device error from > ata_eh_analyze_tf(). > > Suggested-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com> > Suggested-by: Tested-by: Niklas Cassel <niklas.cassel@....com> Nit: is this perhaps a typo? (Since there is another Tested-by tag later in the list.) Checkpatch doesn't complain, so I guess no biggie, but might be worth fixing if you decide to roll a v7. Kind regards, Niklas > Signed-off-by: John Garry <john.garry@...wei.com> > Tested-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com> > Reviewed-by: Jason Yan <yanaijie@...wei.com> > Tested-by: Niklas Cassel <niklas.cassel@....com> # pm80xx
Powered by blists - more mailing lists