linux-kernel - Re: [PATCH AUTOSEL 4.9 1/6] ARM: dts: imx7d-sdb: config the max pressure for tsc2046

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221017111537.GB15612@duo.ucw.cz>
Date:   Mon, 17 Oct 2022 13:15:37 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Haibo Chen <haibo.chen@....com>,
        Shawn Guo <shawnguo@...nel.org>, robh+dt@...nel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH AUTOSEL 4.9 1/6] ARM: dts: imx7d-sdb: config the max
 pressure for tsc2046

Hi!

> From: Haibo Chen <haibo.chen@....com>
> 
> [ Upstream commit e7c4ebe2f9cd68588eb24ba4ed122e696e2d5272 ]
> 
> Use the general touchscreen method to config the max pressure for
> touch tsc2046(data sheet suggest 8 bit pressure), otherwise, for
> ABS_PRESSURE, when config the same max and min value, weston will
> meet the following issue,
> 
> [17:19:39.183] event1  - ADS7846 Touchscreen: is tagged by udev as: Touchscreen
> [17:19:39.183] event1  - ADS7846 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE
> [17:19:39.183] event1  - ADS7846 Touchscreen: was rejected
> [17:19:39.183] event1  - not using input device '/dev/input/event1'
> 
> This will then cause the APP weston-touch-calibrator can't list touch devices.
> 
> root@...6ul7d:~# weston-touch-calibrator
> could not load cursor 'dnd-move'
> could not load cursor 'dnd-copy'
> could not load cursor 'dnd-none'
> No devices listed.
> 
> And accroding to binding Doc, "ti,x-max", "ti,y-max", "ti,pressure-max"
> belong to the deprecated properties, so remove them. Also for "ti,x-min",
> "ti,y-min", "ti,x-plate-ohms", the value set in dts equal to the default
> value in driver, so are redundant, also remove here.

Did someone check the source code in 4.9? AFAICT it still tries to use
the properties, and probing seems to be different from newer kernels.

Best regards,
								Pavel
--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)