linux-kernel - Re: [PATCH AUTOSEL 4.9 03/10] hid: topre: Add driver fixing report descriptor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221017124846.GB13227@duo.ucw.cz>
Date:   Mon, 17 Oct 2022 14:48:46 +0200
From:   Pavel Machek <pavel@...x.de>
To:     Sasha Levin <sashal@...nel.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Harry Stern <harry@...rystern.net>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        jikos@...nel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 4.9 03/10] hid: topre: Add driver fixing report
 descriptor

Hi!

> From: Harry Stern <harry@...rystern.net>
> 
> [ Upstream commit a109d5c45b3d6728b9430716b915afbe16eef27c ]
> 
> The Topre REALFORCE R2 firmware incorrectly reports that interface
> descriptor number 1, input report descriptor 2's events are array events
> rather than variable events. That particular report descriptor is used
> to report keypresses when there are more than 6 keys held at a time.
> This bug prevents events from this interface from being registered
> properly, so only 6 keypresses (from a different interface) can be
> registered at once, rather than full n-key rollover.
> 
> This commit fixes the bug by setting the correct value in a report_fixup
> function.
> 
> The original bug report can be found here:
> Link: https://gitlab.freedesktop.org/libinput/libinput/-/issues/804
> 
> Thanks to Benjamin Tissoires for diagnosing the issue with the report
> descriptor.

Come on, whole new driver to work around hw problem that is not really
serious. Plus this won't really do anything unless people enable it in
config.

This should not be in stable.

Best regards,
								Pavel

> Signed-off-by: Harry Stern <harry@...rystern.net>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Link: https://lore.kernel.org/r/20220911003614.297613-1-harry@harrystern.net
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/hid/Kconfig     |  6 +++++
>  drivers/hid/Makefile    |  1 +
>  drivers/hid/hid-ids.h   |  3 +++
>  drivers/hid/hid-topre.c | 49 +++++++++++++++++++++++++++++++++++++++++

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)