linux-kernel - Re: [PATCH net] net: phy: dp83822: disable MDI crossover status change interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y06fI9OSvRjPe0Cd@lunn.ch>
Date:   Tue, 18 Oct 2022 14:42:11 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Felix Riemann <felix.riemann@....de>
Cc:     Heiner Kallweit <hkallweit1@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: dp83822: disable MDI crossover status
 change interrupt

On Tue, Oct 18, 2022 at 12:47:54PM +0200, Felix Riemann wrote:
> From: Felix Riemann <felix.riemann@....de>
> 
> If the cable is disconnected the PHY seems to toggle between MDI and
> MDI-X modes. With the MDI crossover status interrupt active this causes
> roughly 10 interrupts per second.

Make sense, it is trying to find the RX pair...

> 
> As the crossover status isn't checked by the driver, the interrupt can
> be disabled to reduce the interrupt load.
> 
> Fixes: 87461f7a58ab ("net: phy: DP83822 initial driver submission")
> Signed-off-by: Felix Riemann <felix.riemann@....de>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew