linux-kernel - Re: [PATCH RFC 1/2] kobject: add return value for kobject

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y06je6LiDicUfzto@kroah.com>
Date:   Tue, 18 Oct 2022 15:00:43 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Yu Kuai <yukuai3@...wei.com>
Cc:     hch@....de, axboe@...nel.dk, willy@...radead.org,
        martin.petersen@...cle.com, kch@...dia.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai1@...weicloud.com, yi.zhang@...wei.com
Subject: Re: [PATCH RFC 1/2] kobject: add return value for kobject_put()

On Tue, Oct 18, 2022 at 09:14:31PM +0800, Yu Kuai wrote:
> The return value will be used in later patch to fix uaf for slave_dir
> and bd_holder_dir in block layer.

Then the user will be incorrect, this is not ok, you should never care
if you are the last "put" on an object at all.  Hint, what happens right
after you call this and get the result?

sorry, but NAK.

greg k-h