linux-kernel - Re: [PATCH] serial: tegra: read DMA status before terminating

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 19:03:41 +0530
From:   Kartik <kkartik@...dia.com>
To:     <jonathanh@...dia.com>
CC:     <akhilrajeev@...dia.com>, <gregkh@...uxfoundation.org>,
        <jirislaby@...nel.org>, <kkartik@...dia.com>,
        <ldewangan@...dia.com>, <linux-kernel@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-tegra@...r.kernel.org>,
        <swarren@...dia.com>, <thierry.reding@...il.com>
Subject: Re: [PATCH] serial: tegra: read DMA status before terminating

> The change looks fine to me, but on further review of other similar 
> drivers I see that they pause first ...
> 
>   dmaengine_pause(tup->tx_dma_chan);
>   dmaengine_tx_status(tup->tx_dma_chan, tup->tx_cookie, &state);
>   dmaengine_terminate_all(tup->tx_dma_chan);
> 
> This makes sense so that when we calculate the amount of the data 
> transferred we get the exact amount. Can we add a pause while we are at it?
> 
> Thanks!
> Jon

I agree.. I will include this in v2.

Regards,
Kartik