linux-kernel - Re: [PATCH v2] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 10:35:03 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Vadym Kochan <vadym.kochan@...ision.eu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Elad Nachman <enachman@...vell.com>
Subject: Re: [PATCH v2] usb: ehci-orion: Extend DMA mask to 64 bit for AC5
 platform

On Tue, Oct 18, 2022 at 02:34:00PM +0300, Vadym Kochan wrote:
> From: Elad Nachman <enachman@...vell.com>
> 
> AC5 is a 64-bit platform so extend the dma mask accordingly.
> 
> Checked this mask on armv7 a38x SoC (which has this
> USB controller) platform with simple fs ops on the storage device
> but on older 4.14 Linux version.
> 
> Signed-off-by: Elad Nachman <enachman@...vell.com>
> Signed-off-by: Vadym Kochan <vadym.kochan@...ision.eu>
> ---
> v2:
>    Add missing description.
> 
>  drivers/usb/host/ehci-orion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
> index a3454a3ea4e0..c6205abebbdf 100644
> --- a/drivers/usb/host/ehci-orion.c
> +++ b/drivers/usb/host/ehci-orion.c
> @@ -230,7 +230,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
>  	 * set. Since shared usb code relies on it, set it here for
>  	 * now. Once we have dma capability bindings this can go away.
>  	 */
> -	err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> +	err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
>  	if (err)
>  		goto err;
>  

NAK.  The description says this changes the DMA mask on AC5 platforms to 
64 bits, but that isn't what the patch actually does.  It changes the 
DMA mask on _all_ platforms using the orion hardware.

Alan Stern