linux-kernel - Re: [PATCH] siphash: Convert selftest to KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2022 11:14:43 -0600
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     David Gow <davidgow@...gle.com>, linux-kernel@...r.kernel.org,
        linux-hardening@...r.kernel.org
Subject: Re: [PATCH] siphash: Convert selftest to KUnit

On Tue, Oct 18, 2022 at 11:13 AM Kees Cook <keescook@...omium.org> wrote:
>
> On Tue, Oct 18, 2022 at 11:00:26AM -0600, Jason A. Donenfeld wrote:
> > On Tue, Oct 18, 2022 at 03:05:46AM -0700, Kees Cook wrote:
> > > Convert the siphash self-test to KUnit so it will be included in "all
> > > KUnit tests" coverage, and can be run individually still:
> > >
> > > $ ./tools/testing/kunit/kunit.py run siphash
> > > ...
> > > [02:58:45] Starting KUnit Kernel (1/1)...
> > > [02:58:45] ============================================================
> > > [02:58:45] =================== siphash (1 subtest) ====================
> > > [02:58:45] [PASSED] siphash_test
> > > [02:58:45] ===================== [PASSED] siphash =====================
> > > [02:58:45] ============================================================
> > > [02:58:45] Testing complete. Ran 1 tests: passed: 1
> > > [02:58:45] Elapsed time: 21.421s total, 4.306s configuring, 16.947s building, 0.148s running
> > >
> > > Cc: "Jason A. Donenfeld" <Jason@...c4.com>
> > > Cc: David Gow <davidgow@...gle.com>
> > > Signed-off-by: Kees Cook <keescook@...omium.org>
> >
> > I'll queue this up. Thanks for the conversion. Appears to work well.
>
> Cool! Thanks for looking it over. If we want to avoid some tree
> collisions, I could carry it in my tree? I've got some other conversions
> in progress. Though maybe this begs the question of "how should kunit
> tests be ordered in the Kconfig and Makefile?" so that collisions are
> obvious about how to order...

No problem:

Acked-by: Jason A. Donenfeld <Jason@...c4.com>

Please use a lowercase "convert" in the commit subject, like the other
siphash commits.

Jason