linux-kernel - Re: [PATCH v3 1/3] scsi: ufs: core: Remove unnecessary if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7504ebe7163c1aeb14fb52914a51d603ec0ff796.camel@gmail.com>
Date:   Tue, 18 Oct 2022 20:23:34 +0200
From:   Bean Huo <huobean@...il.com>
To:     Bart Van Assche <bvanassche@....org>, alim.akhtar@...sung.com,
        avri.altman@....com, asutoshd@...eaurora.org, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, stanley.chu@...iatek.com,
        beanhuo@...ron.com, tomas.winkler@...el.com, cang@...eaurora.org,
        daejun7.park@...sung.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/3] scsi: ufs: core: Remove unnecessary if statement

On Tue, 2022-10-18 at 11:20 -0700, Bart Van Assche wrote:
> On 10/18/22 11:16, Bean Huo wrote:
> > From: Bean Huo <beanhuo@...ron.com>
> > 
> > LUs with WB potential support are properly checked in
> > ufshcd_wb_probe()
> > before calling ufshcd_read_unit_desc_param(), so remove this
> > unnecessary
> > if-checkup in ufs_is_valid_unit_desc_lun() to match its function
> > definition.
> 
> Hi Bean,
> 
> Does this patch differ from a revert of Jaegeuk's patch? If not,
> please 
> change the patch title into "Revert scsi: ufs: WB is only available
> on 
> LUN #0 to #7" and add "Cc: Jaegeuk Kim <jaegeuk@...nel.org>" just
> above 
> the Signed-off-by line.
> 
> Thanks,
> 
> Bart.

Bart, 

no difference, I will change its title and CC Jaegeuk.

thanks,
Bean