linux-kernel - Re: [PATCH] irqchip: add TS7800v1 fpga based controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b4011de0-d5a4-4083-aa0d-2fe5861ba4d6@app.fastmail.com>
Date:   Tue, 18 Oct 2022 20:51:01 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Marc Zyngier" <maz@...nel.org>,
        "Firas Ashkar" <firas.ashkar@...oirfairelinux.com>
Cc:     alex@...riz.org.uk, "Thomas Gleixner" <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org, inux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] irqchip: add TS7800v1 fpga based controller driver

On Tue, Oct 18, 2022, at 18:36, Marc Zyngier wrote:

>>  }
>> @@ -371,6 +418,12 @@ static int ts78xx_fpga_load_devices(void)
>>  {
>>  	int tmp, ret = 0;
>>  
>> +	if (ts78xx_fpga.supports.ts_irqc.present == 1) {
>> +		tmp = ts_irqc_load();
>> +		if (tmp)
>> +			ts78xx_fpga.supports.ts_irqc.present = 0;
>> +		ret |= tmp;
>> +	}
>>  	if (ts78xx_fpga.supports.ts_rtc.present == 1) {
>>  		tmp = ts78xx_ts_rtc_load();
>>  		if (tmp)
>> @@ -402,6 +455,8 @@ static int ts78xx_fpga_unload_devices(void)
>>  		ts78xx_ts_nand_unload();
>>  	if (ts78xx_fpga.supports.ts_rng.present == 1)
>>  		ts78xx_ts_rng_unload();
>> +	if (ts78xx_fpga.supports.ts_irqc.present == 1)
>> +		ts_irqc_unload();
>>  
>>  	return 0;
>>  }
>
> I am absolutely *NOT* keen on adding more non-DT stuff in this day and
> age. The DT effort has been going on for over 10 years, and maybe it
> is time that this board makes the jump before we add anything new to
> it, specially given that there is a DT board for this platform.
>
> Arnd, what's your call on this?

I'm in the middle of sending out the patch series that removes
most of the legacy board files:

https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=boardfile-remove

TS78xx actually stays for now because this is one of the
machines enabled in the debian armel tree, but my hope is
for the remaining 27 board files, we can either complete
the DT conversion or just remove them in the future.

Aside from the FPGA, this machine should be fairly easy to
convert, so I agree we should try doing this first. Not
sure how the FPGA is best represented, but I'm sure we can come
up with something once the rest of the system is working
with DT.

      Arnd