[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202210181159.1B36049D3@keescook>
Date: Tue, 18 Oct 2022 12:00:58 -0700
From: Kees Cook <keescook@...omium.org>
To: Nathan Chancellor <nathan@...nel.org>
Cc: David Gow <davidgow@...gle.com>,
"Tobin C . Harding" <tobin@...nel.org>,
linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] string: Convert strscpy() self-test to KUnit
On Tue, Oct 18, 2022 at 11:54:28AM -0700, Nathan Chancellor wrote:
> On Tue, Oct 18, 2022 at 01:28:59AM -0700, Kees Cook wrote:
> > Convert the strscpy() self-test to a KUnit test.
> >
> > Cc: David Gow <davidgow@...gle.com>
> > Cc: Tobin C. Harding <tobin@...nel.org>
> > Signed-off-by: Kees Cook <keescook@...omium.org>
>
> I ran the following commands and they all passed:
>
> $ tools/testing/kunit/kunit.py run --arch arm64 --cross_compile aarch64-linux-gnu- strscpy
>
> $ tools/testing/kunit/kunit.py run --arch arm64 --make_options LLVM=1 strscpy
>
> $ tools/testing/kunit/kunit.py run --arch x86_64 strscpy
>
> $ tools/testing/kunit/kunit.py run --arch x86_64 --make_options LLVM=1 strscpy
>
> Tested-by: Nathan Chancellor <nathan@...nel.org>
Thank you!
I should probably note somewhere that I test it both with and without
CONFIG_FORTIFY_SOURCE:
$ tools/testing/kunit/kunit.py run --arch x86_64 --kconfig_add CONFIG_FORTIFY_SOURCE=y strscpy
etc...
--
Kees Cook
Powered by blists - more mailing lists