linux-kernel - Re: [PATCH] srcu: Export srcu_check_nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEXW_YSaFKb7uv+wQnfdEEm41tAiXjEb=bge_0AtNFsQ2s-6Ug@mail.gmail.com>
Date:   Tue, 18 Oct 2022 15:05:33 -0400
From:   Joel Fernandes <joel@...lfernandes.org>
To:     paulmck@...nel.org
Cc:     Frederic Weisbecker <frederic@...nel.org>,
        Zqiang <qiang1.zhang@...el.com>, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] srcu: Export srcu_check_nmi_safety() to modules

On Tue, Oct 18, 2022 at 1:50 PM Paul E. McKenney <paulmck@...nel.org> wrote:
>
> On Tue, Oct 18, 2022 at 12:45:33PM +0200, Frederic Weisbecker wrote:
> > On Tue, Oct 18, 2022 at 09:39:06AM +0800, Zqiang wrote:
> > > When enable CONFIG_PROVE_RCU and built modules, the following
> > > error appear:
> > >
> > > ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcutorture.ko] undefined!
> > > ERROR: modpost: "srcu_check_nmi_safety" [kernel/rcu/rcuscale.ko] undefined!
> > >
> > > This commit fix it by exporting the srcu_check_nmi_safety().
> > >
> > > Signed-off-by: Zqiang <qiang1.zhang@...el.com>
> >
> > Paul, whichever way you prefer, editing the commit or adding this
> > one on top.
> >
> > Reviewed-by: Frederic Weisbecker <frederic@...nel.org>
>
> Thank you all!
>
> This is what I currently have, folded into Frederic's original.
>
> Thoughts?

Looks good to me, has this caught any issues yet?

Thanks.