[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y08LJEt8B/Zgv4Gs@hirez.programming.kicks-ass.net>
Date: Tue, 18 Oct 2022 22:23:00 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: James Clark <james.clark@....com>
Cc: linux-perf-users@...r.kernel.org, namhyung@...nel.org,
linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH] perf: Fix missing raw data on tracepoint events
On Wed, Oct 12, 2022 at 03:38:57PM +0100, James Clark wrote:
> Since commit 838d9bb62d13 ("perf: Use sample_flags for raw_data")
> raw data is not being output on tracepoints due to the PERF_SAMPLE_RAW
> field not being set. Fix this by setting it for tracepoint events.
>
> This fixes the following test failure:
>
> perf test "sched_switch" -vvv
>
> 35: Track with sched_switch
> --- start ---
> test child forked, pid 1828
> ...
> Using CPUID 0x00000000410fd400
> sched_switch: cpu: 2 prev_tid -14687 next_tid 0
> sched_switch: cpu: 2 prev_tid -14687 next_tid 0
> Missing sched_switch events
> 4613 events recorded
> test child finished with -1
> ---- end ----
> Track with sched_switch: FAILED!
>
> Fixes: 838d9bb62d13 ("perf: Use sample_flags for raw_data")
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
> Signed-off-by: James Clark <james.clark@....com>
Thanks!
Powered by blists - more mailing lists